Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize request parsing to use a single path handler #7106

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 3, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

统一使用同一个 RequestPath 来解析请求信息

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 3, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Dec 3, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Dec 3, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby December 3, 2024 10:44
Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.25%. Comparing base (eff73dc) to head (ba4b6bd).
Report is 69 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7106      +/-   ##
============================================
+ Coverage     56.99%   57.25%   +0.25%     
- Complexity     3999     4021      +22     
============================================
  Files           714      713       -1     
  Lines         24110    24212     +102     
  Branches       1585     1593       +8     
============================================
+ Hits          13742    13863     +121     
+ Misses         9756     9735      -21     
- Partials        612      614       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
Copy link

f2c-ci-robot bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 7bd9408 into halo-dev:main Dec 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants